Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create separate sticky bit command #491

Merged

Conversation

pretendWhale
Copy link
Contributor

Previously, we discovered an issue with test directories with the sticky bit set. To fix it, we updated the command that changes permissions such that it explicitly unsets the sticky bit on all directories in the autotest worker directory before attempting to delete the contents of the directory, as part of other permissions changes required.

However, this prevents the standard permission changes (ugo+rwX) from being applied to files within directories.

This is an issue if, for example, the tests create their own files and directories and do not explicitly set them to be group executable, because anything within those directories will not be deletable by the autotst user.

This PR updates the sticky bit change to run as an entirely separate command.

tested against folders copied from instructor files, as well as folders created by the tests themselves, both with and without the sticky bit applied.

Tests need to be written before this PR can be undrafted

@pretendWhale pretendWhale marked this pull request as ready for review March 20, 2024 18:34
@donny-wong donny-wong added this to the v2.4.1 milestone Mar 20, 2024
@david-yz-liu david-yz-liu merged commit 12f2890 into MarkUsProject:master Mar 22, 2024
14 checks passed
@pretendWhale pretendWhale modified the milestones: v2.4.1, v2.4.2 Apr 3, 2024
pretendWhale added a commit to pretendWhale/markus-autotesting that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants